NihalJain commented on PR #15861: URL: https://github.com/apache/pinot/pull/15861#issuecomment-2912139771
> Making sure I understand the goal correctly: > > * Common code for each of controller, broker & server have been moved to abstract classes in each of the packages. > * Common code across package - `getPrincipal` has been moved to `core.auth.BasicAuthUtils` Hi @vrajat Yes this is correct! > I know there are tests for Basic auth for broker & controller. Are there tests for server auth AND for zk auth ? Can you also mention any manual tests that you have done ? I had tested it by running a few tests locally, basically I started all components in Pinot with both ZK and Basic Auth, one at a time, and validated few APIs, in each service, to confirm if they work fine. It has been a while when I ran those locally, let me spend some more time and redo the tests. Meanwhile do you mind going over the code to see if there are any concerns with the approach? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
