gortiz commented on code in PR #15445:
URL: https://github.com/apache/pinot/pull/15445#discussion_r2100560913
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/server/QueryServer.java:
##########
@@ -81,7 +79,8 @@ public class QueryServer extends
PinotQueryWorkerGrpc.PinotQueryWorkerImplBase {
// query submission service is only used for plan submission for now.
// TODO: with complex query submission logic we should allow asynchronous
query submission return instead of
// directly return from submission response observer.
- private final ExecutorService _querySubmissionExecutorService;
+ private final ExecutorService _submissionExecutorService;
Review Comment:
The only reason we actually need the submission executor service now is to
be able to abort the submission on timeout. Given we should not block, it
shouldn't be an actual issue (unless timeout is in the order of units of ms we
should have enough time to submit the requests!) but I preferred to be safe,
covering the case where we add blocking code in the future by mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
