gortiz commented on code in PR #15445:
URL: https://github.com/apache/pinot/pull/15445#discussion_r2100545349
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/server/QueryServer.java:
##########
@@ -81,7 +79,8 @@ public class QueryServer extends
PinotQueryWorkerGrpc.PinotQueryWorkerImplBase {
// query submission service is only used for plan submission for now.
// TODO: with complex query submission logic we should allow asynchronous
query submission return instead of
// directly return from submission response observer.
- private final ExecutorService _querySubmissionExecutorService;
+ private final ExecutorService _submissionExecutorService;
+ private final ExecutorService _explainExecutorService;
Review Comment:
I decided to run explain in another thread pool, given that the work to be
done in explain is a bit heavier than the one during submission.
Notice that cancel is also run in another thread. In this case in the grpc
thread itself. This guarantees that no matter which executor we use for
submission, cancel request will never be blocked by queries being submitted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
