gortiz commented on code in PR #15869:
URL: https://github.com/apache/pinot/pull/15869#discussion_r2101973635
##########
pinot-core/src/main/java/org/apache/pinot/core/query/executor/SingleTableExecutionInfo.java:
##########
@@ -151,18 +152,18 @@ private SingleTableExecutionInfo(TableDataManager
tableDataManager, List<Segment
_notAcquiredSegments = notAcquiredSegments;
}
- @Override
- public boolean hasRealtime() {
- return _tableDataManager instanceof RealtimeTableDataManager;
- }
-
-
public TableDataManager getTableDataManager() {
return _tableDataManager;
}
- public List<SegmentDataManager> getSegmentDataManagers() {
- return _segmentDataManagers;
+ @Override
+ public Schema getSchema() {
+ return _tableDataManager.getCachedTableConfigAndSchema().getRight();
Review Comment:
Including the schema on every request could be quite expensive, don't you
think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
