gortiz commented on code in PR #15869: URL: https://github.com/apache/pinot/pull/15869#discussion_r2101979544
########## pinot-core/src/test/java/org/apache/pinot/core/plan/maker/QueryOverrideWithHintsTest.java: ########## @@ -37,82 +33,26 @@ import org.apache.pinot.core.query.request.context.QueryContext; import org.apache.pinot.core.query.request.context.utils.QueryContextConverterUtils; import org.apache.pinot.segment.spi.IndexSegment; -import org.apache.pinot.segment.spi.SegmentMetadata; -import org.apache.pinot.segment.spi.datasource.DataSource; -import org.apache.pinot.segment.spi.index.mutable.ThreadSafeMutableRoaringBitmap; -import org.apache.pinot.segment.spi.index.startree.StarTreeV2; import org.apache.pinot.spi.data.FieldSpec; -import org.apache.pinot.spi.data.readers.GenericRow; import org.apache.pinot.sql.parsers.CalciteSqlParser; +import org.mockito.Mockito; Review Comment: are we sure we want to rely even more in Mockito? IMHO mocks are usually a code smell and they just add technical debt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
