siddharthteotia commented on code in PR #16018:
URL: https://github.com/apache/pinot/pull/16018#discussion_r2206480469
##########
pinot-core/src/test/java/org/apache/pinot/core/accounting/WorkloadBudgetManagerTest.java:
##########
@@ -115,4 +115,31 @@ void testConcurrentTryChargeSingleWorkload() throws
InterruptedException {
assertEquals(initialMemBudget - totalMemCharged,
remaining._memoryRemaining,
"Memory budget mismatch after concurrent updates");
}
+
+ @Test
+ void testCanAdmitQuery() {
Review Comment:
Are these tests enough to get good coverage of all scenarios / combinations
? How are we validating that ?
Do we have a theoretical version / model of different permutations and
combinations that we are using to test the functionality ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
