vvivekiyer commented on code in PR #16018:
URL: https://github.com/apache/pinot/pull/16018#discussion_r2240553850
##########
pinot-spi/src/main/java/org/apache/pinot/core/accounting/WorkloadBudgetManager.java:
##########
@@ -47,10 +47,36 @@ public WorkloadBudgetManager(PinotConfiguration config) {
}
_enforcementWindowMs =
config.getProperty(CommonConstants.Accounting.CONFIG_OF_WORKLOAD_ENFORCEMENT_WINDOW_MS,
CommonConstants.Accounting.DEFAULT_WORKLOAD_ENFORCEMENT_WINDOW_MS);
+ initSecondaryWorkloadBudget(config);
Review Comment:
As discussed in earlier comments, we should keep this optional. Not all
users will be migrating from BinaryWorkloadScheduler. If
DEFAULT_SECONDARY_WORKLOAD_NAME is not populated, maybe we can skip
initializing?
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -125,6 +129,7 @@ public BaseBrokerRequestHandler(PinotConfiguration config,
String brokerId, Brok
_queriesById = null;
_clientQueryIds = null;
}
+ _resourceUsageAccountant = resourceUsageAccountant;
Review Comment:
Why do we need this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
