raghavyadav01 commented on code in PR #16560:
URL: https://github.com/apache/pinot/pull/16560#discussion_r2263849806
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/MailboxService.java:
##########
@@ -78,7 +81,18 @@ public MailboxService(String hostname, int port,
PinotConfiguration config, @Nul
_port = port;
_config = config;
_tlsConfig = tlsConfig;
- _channelManager = new ChannelManager(tlsConfig);
+ long pingerPeriodMs = config.getProperty(
+ CommonConstants.MultiStageQueryRunner.KEY_OF_PINGER_PERIOD_SECONDS,
+ CommonConstants.MultiStageQueryRunner.DEFAULT_PINGER_PERIOD_SECONDS);
+ Duration pingerPeriod = Duration.ofSeconds(pingerPeriodMs);
+
+ _channelManager = new ChannelManager(tlsConfig, pingerPeriod);
+
+ if (pingerPeriodMs > 0) {
Review Comment:
Are we pining after every pingerPeriodMs or is it possible to have metic to
say when last grpc call was made and then issue ping ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
