yashmayya commented on code in PR #16560:
URL: https://github.com/apache/pinot/pull/16560#discussion_r2299860017
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/channel/ChannelManager.java:
##########
@@ -36,32 +41,69 @@
* query/job/stages.
*/
public class ChannelManager {
+ /**
+ * Map from (hostname, port) to the ManagedChannel with all known channels
+ */
private final ConcurrentHashMap<Pair<String, Integer>, ManagedChannel>
_channelMap = new ConcurrentHashMap<>();
private final TlsConfig _tlsConfig;
+ /**
+ * The idle timeout for the channel, which cannot be disabled in gRPC.
Review Comment:
Just checking once again - why can't we default to setting the idle timeout
to `Long.MAX_VALUE` which would basically disable the idle mode for gRPC
channels. We could still allow configuring the idle timeout manually, but this
would preclude the need for this pinger mechanism altogether, no? This has even
been suggested by maintainers of `grpc-java`
[here](https://github.com/grpc/grpc-java/issues/2022#issuecomment-1059294635).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
