bziobrowski commented on code in PR #16658:
URL: https://github.com/apache/pinot/pull/16658#discussion_r2293229121


##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/NullHandlingIntegrationTest.java:
##########
@@ -351,6 +359,42 @@ public void testWindowFunctionIgnoreNulls()
     }
   }
 

Review Comment:
   Does the rule affect  `IS NULL` ? 
   e.g. 
   is 
   ```sql
   salary IS NULL
   and salary = -2147483648
   ```
   treated as contradiction / empty filter  when null handling is disabled ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to