yashmayya commented on code in PR #16658:
URL: https://github.com/apache/pinot/pull/16658#discussion_r2300575852
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java:
##########
@@ -147,20 +147,30 @@ public QueryEnvironment(Config config) {
String database = config.getDatabase();
_catalog = new PinotCatalog(config.getTableCache(), database);
CalciteSchema rootSchema = CalciteSchema.createRootSchema(false, false,
database, _catalog);
- _config =
Frameworks.newConfigBuilder().traitDefs().operatorTable(PinotOperatorTable.instance())
-
.defaultSchema(rootSchema.plus()).sqlToRelConverterConfig(PinotRuleUtils.PINOT_SQL_TO_REL_CONFIG).build();
+ _config = Frameworks.newConfigBuilder()
+ .traitDefs()
+
.operatorTable(PinotOperatorTable.instance(config.isNullHandlingEnabled()))
+ .defaultSchema(rootSchema.plus())
+ .sqlToRelConverterConfig(PinotRuleUtils.PINOT_SQL_TO_REL_CONFIG)
+ .build();
_catalogReader = new PinotCatalogReader(
rootSchema, List.of(database), _typeFactory, CONNECTION_CONFIG,
config.isCaseSensitive());
// default optProgram with no skip rule options and no use rule options
_optProgram = getOptProgram(Set.of(), Set.of());
}
public QueryEnvironment(String database, TableCache tableCache, @Nullable
WorkerManager workerManager) {
+ this(database, tableCache, workerManager, true);
Review Comment:
We're defaulting to null handling being enabled? Shouldn't we use this
broker config instead - https://github.com/apache/pinot/pull/13977?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
