suvodeep-pyne commented on code in PR #16662:
URL: https://github.com/apache/pinot/pull/16662#discussion_r2301938150
##########
pinot-common/src/main/java/org/apache/pinot/common/audit/AuditConfigManager.java:
##########
@@ -154,9 +152,9 @@ public boolean isEndpointExcluded(String endpoint) {
}
@Override
- public void onClusterConfigChange(ClusterConfig clusterConfig,
NotificationContext context) {
+ public void onChange(Set<String> changedConfigs, Map<String, String>
clusterConfigs) {
try {
- _currentConfig = buildFromClusterConfig(clusterConfig);
+ _currentConfig = buildFromClusterConfig(clusterConfigs);
Review Comment:
Defaults are set in the AuditConfig class. this actually happens
automatically. Added a test to validate that as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
