suvodeep-pyne commented on PR #16662: URL: https://github.com/apache/pinot/pull/16662#issuecomment-3225471121
@somandal > One question on testing - did you try this out with QuickStart and verify that the ZK updates are happening correctly? If not, recommend doing some testing on that end to ensure that everything works (old server side code and the new changes you added) Yes. I used quickstart to validate this and then updated cluster config to generate audit logs. Also, I added an if check to only update configs if audit log related configs update. Although, performance wise this should be very minimal in terms of impact, I think it might be cleaner. Updated the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
