J-HowHuang commented on code in PR #17453:
URL: https://github.com/apache/pinot/pull/17453#discussion_r2687764432


##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SegmentOnlineOfflineStateModelFactory.java:
##########
@@ -247,4 +254,43 @@ public void onBecomeDroppedFromError(Message message, 
NotificationContext contex
       }
     }
   }
+
+  /**
+   *Get thread pool to handle the given state transition message.
+   * If this method returns null, the threadpool returned from
+   * {@link StateModelFactory#getExecutorService(String resourceName, String 
fromState, String toState)} will be used;
+   * it this method returns null the threadpool returned from
+   * {@link StateModelFactory#getExecutorService(String resourceName)} will be 
used.
+   * If that method return null too, then the default shared threadpool will 
be used.
+   * This method may be called only once for each category of messages,
+   * it will NOT be called during each state transition.
+   * @param messageInfo contains information used to categorize messages to 
use different threadpools
+   * @return An object contains the MessageIdentifierBase and the assigned 
threadpool for the input message
+   */
+  @Override
+  @Nullable
+  public CustomizedExecutorService getExecutorService(Message.MessageInfo 
messageInfo) {
+    if (_stateTransitionThreadPoolManager == null) {
+      return null;

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to