yashmayya commented on code in PR #17453:
URL: https://github.com/apache/pinot/pull/17453#discussion_r2692373669
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java:
##########
@@ -183,6 +183,8 @@ public abstract class BaseServerStarter implements
ServiceStartable {
protected volatile boolean _isServerReadyToServeQueries = false;
protected ScheduledExecutorService _helixMessageCountScheduler;
protected ServerReloadJobStatusCache _reloadJobStatusCache;
+ // Override this to provide custom thread pool for Helix state transitions.
Null means using Helix's default
+ protected StateTransitionThreadPoolManager _transitionThreadPoolManager;
Review Comment:
Might be cleaner to have an overrideable setter method or something similar
to explicitly initialize this field, given that it's being used in the `init`
method here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
