deepthi912 commented on code in PR #17503:
URL: https://github.com/apache/pinot/pull/17503#discussion_r2696533818
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -746,12 +747,11 @@ void
revertSegmentUpsertMetadataWithRetry(ImmutableSegment segment, ThreadSafeMu
}
}
- protected abstract void removeNewlyAddedKeys(IndexSegment oldSegment);
-
protected abstract void eraseKeyToPreviousLocationMap();
Review Comment:
https://github.com/apache/pinot/pull/17503#discussion_r2696432742
I have `eraseKeyToPreviousLocationMap` method because, once a consuming
segment is replaced, it is better to erase the keys and start the map fresh
after each segment replacement, otherwise I don't want to keep on adding keys
which could get larger over time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
