deepthi912 commented on code in PR #17503:
URL: https://github.com/apache/pinot/pull/17503#discussion_r2723199776
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -2171,12 +2171,33 @@ public static class ConfigChangeListenerConstants {
* Cluster config key to control whether force commit/reload is allowed
for upsert tables
* with inconsistent state configurations (partial upsert or
dropOutOfOrderRecord=true
* with consistency mode NONE and replication > 1).
+ *
+ * Supported values: NONE, PROTECTED, UNSAFE
+ * Legacy boolean values (true/false) are also supported for backward
compatibility.
+ * @deprecated Use {@link #CONSUMING_SEGMENT_COMMIT_CONFIG} instead.
*/
+ @Deprecated
public static final String FORCE_COMMIT_RELOAD_CONFIG =
"pinot.server.upsert.force.commit.reload";
+ /**
+ * Cluster config key to control the commit mode for consuming segments in
upsert tables.
+ *
+ * Supported values: NONE, PROTECTED, UNSAFE
+ * Legacy boolean values (true/false) are also supported for backward
compatibility.
+ */
+ public static final String CONSUMING_SEGMENT_COMMIT_CONFIG =
"pinot.server.consuming.segment.commit.mode";
Review Comment:
Cool, let me remove this property entirely
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
