yashmayya commented on code in PR #17576:
URL: https://github.com/apache/pinot/pull/17576#discussion_r2761002250
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -2031,6 +2031,13 @@ public static class MultiStageQueryRunner {
public static final String KEY_OF_SEND_STATS_MODE =
"pinot.query.mse.stats.mode";
public static final String DEFAULT_SEND_STATS_MODE = "SAFE";
+ /// Used to indicate whether MSE pipeline breaker stats should be kept in
the query stats.
+ /// Before 1.5.0, MSE pipeline breaker stats were not kept. Starting from
1.5.0, they are kept by default.
+ ///
+ /// It doesn't seem necessary to disable this behavior, but we keep this
flag for flexibility.
+ public static final String KEY_OF_KEEP_PIPELINE_BREAKER_STATS =
"pinot.query.mse.keep.pipeline.breaker.stats";
Review Comment:
Why is the backward compatibility check failing even if we're disabling this
by default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
