gortiz commented on code in PR #17576:
URL: https://github.com/apache/pinot/pull/17576#discussion_r2770149529
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -2031,6 +2031,13 @@ public static class MultiStageQueryRunner {
public static final String KEY_OF_SEND_STATS_MODE =
"pinot.query.mse.stats.mode";
public static final String DEFAULT_SEND_STATS_MODE = "SAFE";
+ /// Used to indicate whether MSE pipeline breaker stats should be kept in
the query stats.
+ /// Before 1.5.0, MSE pipeline breaker stats were not kept. Starting from
1.5.0, they are kept by default.
+ ///
+ /// It doesn't seem necessary to disable this behavior, but we keep this
flag for flexibility.
+ public static final String KEY_OF_KEEP_PIPELINE_BREAKER_STATS =
"pinot.query.mse.keep.pipeline.breaker.stats";
Review Comment:
I found the issue. It seems the SendStatsPredicate.Safe doesn't work when a
server/broker in versions 1.4 or 1.5 is downgraded to 1.3. The reason for this
is that this mechanism is based on a helix attribute we started to use in 1.4
where we store the current service version. When we rollback to 1.3 the
server/broker doesn't know it has to set that attribute, so the attribute is
not modified and kept as the old value. When the other nodes see that a node
was rollbacked they look for its version but given they found the old value
they think everything is fine.
Notice that this issue is unrelated to this PR. It is just that this PR
breaks compatibility in a way the compatibility framework is able to detect the
issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
