gortiz commented on code in PR #17667:
URL: https://github.com/apache/pinot/pull/17667#discussion_r2782615298
##########
pinot-core/src/main/java/org/apache/pinot/core/transport/DirectOOMHandler.java:
##########
@@ -70,6 +70,10 @@ public void channelInactive(ChannelHandlerContext ctx) {
if (_silentShutDown) {
return;
}
+ // Remove from _allChannels on server side so we don't leak channel
references when brokers disconnect
+ if (_allChannels != null) {
+ _allChannels.remove(ctx.channel());
+ }
Review Comment:
That is ok. If we are in the middle of a shutdown the JVM process will
finish anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
