gortiz commented on code in PR #17667:
URL: https://github.com/apache/pinot/pull/17667#discussion_r2783815287
##########
pinot-core/src/main/java/org/apache/pinot/core/transport/DataTableHandler.java:
##########
@@ -92,12 +92,18 @@ protected void channelRead0(ChannelHandlerContext ctx,
ByteBuf msg) {
LOGGER.error("Caught exception while deserializing data table of size:
{} from server: {}", responseSize,
_serverRoutingInstance, e);
_brokerMetrics.addMeteredGlobalValue(BrokerMeter.DATA_TABLE_DESERIALIZATION_EXCEPTIONS,
1);
+ // Propagate so the pipeline closes the channel and channelInactive runs
(markServerDown), otherwise
+ // the query would hang waiting for a response that will never be
delivered.
+ ctx.fireExceptionCaught(e);
Review Comment:
Maybe isntead of closing the channel here we want to tell the router that
the query has finished incorrectly. But we need to do something beyond dropping
the message we weren't able to parse
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
