J-HowHuang commented on code in PR #17623: URL: https://github.com/apache/pinot/pull/17623#discussion_r2785135960
########## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/DefaultStateTransitionThreadPoolManager.java: ########## @@ -0,0 +1,86 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.server.starter.helix; + +import com.google.common.util.concurrent.ThreadFactoryBuilder; +import java.util.concurrent.Callable; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Future; +import java.util.concurrent.LinkedBlockingQueue; +import java.util.concurrent.ThreadPoolExecutor; +import java.util.concurrent.TimeUnit; +import javax.annotation.Nullable; +import org.apache.helix.messaging.handling.MessageTask; +import org.apache.helix.model.Message; +import org.apache.helix.participant.statemachine.StateModelFactory; +import org.apache.pinot.core.data.manager.SegmentOperationsTaskType; +import org.apache.pinot.core.data.manager.SegmentOperationsTaskWrapper; + + +/** + * Default state transition thread pool manager backed by a fixed-size pool. + */ +public class DefaultStateTransitionThreadPoolManager implements StateTransitionThreadPoolManager { + private static final int DEFAULT_POOL_SIZE = 40; + + private final ExecutorService _executorService; + + public DefaultStateTransitionThreadPoolManager() { + _executorService = new ContextWrappingExecutor(DEFAULT_POOL_SIZE, DEFAULT_POOL_SIZE, 0L, TimeUnit.MILLISECONDS, Review Comment: This is to align with the default thread pool used in Helix. We can have better implementation on this but given that this is the "default" `StateTransitionThreadPoolManager` implementation I made it identical to the current Pinot behavior. Do you feel we should tune the thread pool here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
