J-HowHuang commented on code in PR #17623:
URL: https://github.com/apache/pinot/pull/17623#discussion_r2789049769
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java:
##########
@@ -300,7 +300,7 @@ public void init(PinotConfiguration serverConf)
* Override to provide custom transition thread pool manager
*/
protected void initTransitionThreadPoolManager() {
- _transitionThreadPoolManager = null;
+ _transitionThreadPoolManager = new
DefaultStateTransitionThreadPoolManager();
Review Comment:
If we left this as null, state transition tasks will be left "untagged" with
the task context, which I don't think is a good practice with this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
