Jackie-Jiang commented on code in PR #17678:
URL: https://github.com/apache/pinot/pull/17678#discussion_r2796201180
##########
pinot-spi/pom.xml:
##########
@@ -240,6 +240,10 @@
<groupId>org.roaringbitmap</groupId>
<artifactId>RoaringBitmap</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.helix</groupId>
+ <artifactId>helix-core</artifactId>
Review Comment:
+1. And this is the main reason why we have a separate
`TableConfigSerDeUtils` in `pinot-common`.
In order to override the ser/de behavior of them, you should make the ser/de
component pluggable, but keep it within `pinot-common` to not pollute
`pinot-spi`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
