krishan1390 commented on code in PR #17678: URL: https://github.com/apache/pinot/pull/17678#discussion_r2844360265
########## pinot-spi/src/main/java/org/apache/pinot/spi/config/ConfigRecord.java: ########## @@ -0,0 +1,68 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.config; + +import java.util.Collections; +import java.util.Map; +import javax.annotation.Nullable; + + +/** + * A helix-agnostic record that mirrors ZNRecord's data structure (id, simpleFields, mapFields). + * Config classes in pinot-spi use this for serialization/deserialization, while bridge utilities + * in pinot-common handle conversion between ConfigRecord and ZNRecord. + */ +public class ConfigRecord { Review Comment: I don't think we can manage without this class, because we want the serialisation code `toConfigRecord` to be extendable for classes that extend `LogicalTableConfig`. Without having the Helix dependency in the SPI layer, I don't think we can do that easily. Another way is if we avoid using simple fields and just store the `LogicalTableConfig` as a pure JSON, then it can work, but since that's not how `TableConfig` or `LogicalTableConfig` is stored currently, it will be a backwards incompatible change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
