xiangfu0 commented on PR #17707: URL: https://github.com/apache/pinot/pull/17707#issuecomment-3915740109
Addressed follow-up comments in 899b092f90:\n\n- Added tests for the missing edge cases:\n - partition-id fallback path ()\n - paused-table cleanup path ()\n - non-CONSUMING committing segment cleanup/error path ()\n- Updated fake test manager to enforce the CONSUMING precondition and pause-aware new-segment add behavior, so tests now exercise the moved validation semantics more faithfully.\n- Applied small nits from review:\n - simplified redundant condition on segment movement\n - reduced cleanup success log level to DEBUG\n - added explicit INFO context when metadata is cleaned because segment was not added to IdealState\n\nI left the two broader design tradeoff threads (re-introducing pre-Step2 pause checks / early pre-Step1 CONSUMING check) unresolved in this patch because both approaches require an additional large IdealState read in the hot path, which would partially negate the memory-footprint objective of this PR. Happy to follow up with a dedicated approach if we want a separate correctness-vs-memory tradeoff change there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
