shivam-startree commented on code in PR #17776:
URL: https://github.com/apache/pinot/pull/17776#discussion_r2867308881
##########
pinot-plugins/pinot-stream-ingestion/pinot-kafka-base/src/main/java/org/apache/pinot/plugin/stream/kafka/KafkaSSLUtils.java:
##########
@@ -59,7 +59,7 @@ private KafkaSSLUtils() {
private static final String DEFAULT_KEY_ALGORITHM = "RSA";
private static final String DEFAULT_KEYSTORE_TYPE = "PKCS12";
private static final String DEFAULT_SECURITY_PROTOCOL = "SSL";
- private static final String DEFAULT_TRUSTSTORE_TYPE = "jks";
+ private static final String DEFAULT_TRUSTSTORE_TYPE =
KeyStore.getDefaultType();
Review Comment:
On standard JDKs, KeyStore.getDefaultType() returns "jks" (the same value
we had hardcoded), so existing users see identical behavior. The only
difference is that JVMs configured with a different default keystore type (via
java.security properties) will now get the correct type automatically instead
of being forced to "jks". Users can still override this via explicit Kafka SSL
configuration properties as before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
