Copilot commented on code in PR #17776:
URL: https://github.com/apache/pinot/pull/17776#discussion_r2867312323
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/tls/JvmDefaultSslContext.java:
##########
@@ -102,7 +123,6 @@ public static synchronized void initDefaultSslContext() {
RenewableTlsUtils.enableAutoRenewalFromFileStoreForSSLFactory(jvmSslFactory,
jvmKeystoreType, jvmKeyStorePath,
jvmKeystorePassword, jvmTrustStoreType, jvmTrustStorePath,
jvmTrustStorePassword, null, null, () -> false);
}
- _initialized = true;
- LOGGER.info("Successfully initialized mvm default SSL context");
+ LOGGER.info("Successfully initialized JVM default SSL context");
}
Review Comment:
`LOGGER.info("Successfully initialized JVM default SSL context")` is logged
unconditionally even when the method didn’t actually set a new default
SSLContext (e.g., when neither `javax.net.ssl.keyStore` nor
`javax.net.ssl.trustStore` is provided, or when non-file schemes are used).
Consider logging success only when initialization was performed, and log a
different message (or nothing) when the method no-ops.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
