rohityadav1993 opened a new pull request, #17791: URL: https://github.com/apache/pinot/pull/17791
`testing`, `refactor` ## Fix Pinot Flink Connector Integration Tests ### Description Found while updating pinot-docs: https://github.com/pinot-contrib/pinot-docs/pull/472 This PR fixes the Pinot Flink Connector integration tests that were previously not running during the test phase due to: 1. Test file naming not matching the Maven Surefire plugin configuration 2. Missing `assertj-core` test dependency required by `BaseClusterIntegrationTest` ### Changes 1. **Renamed test classes to match integration test pattern as per root pom.xml:** - `PinotSinkIntegrationTest.java` → `PinotSinkIntegrationTestIT.java` - `PinotSinkIntegrationTestUpsertTable.java` → `PinotSinkIntegrationTestUpsertTableIT.java` - Updated class names inside both files to match new filenames 2. **Added missing test dependency:** - Added `assertj-core` to test scope in `pinot-connectors/pinot-flink-connector/pom.xml` - This dependency is required by the `BaseClusterIntegrationTest` parent class 3. Cleaned up maven-surefire-plugin in module pom so that it is consistent and inherits room pom. ### Test Results Both integration tests now run successfully: - ✅ `PinotSinkIntegrationTestITCase.testPinotSinkWrite` - Tests single-threaded and parallel Flink data writing to Pinot - ✅ `PinotSinkIntegrationTestUpsertTableITCase.testPinotSinkWrite` - Tests Flink upsert table integration Tests can be run with: ./mvnw -pl pinot-connectors/pinot-flink-connector integration-test -DSKIP_INTEGRATION_TESTS=false -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
