rohityadav1993 commented on PR #17791: URL: https://github.com/apache/pinot/pull/17791#issuecomment-4006492741
> Where is assertj used in BaseClusterIntegrationTest? Got mixed up, I see only testng is needed, removed assertj > After changing the pom config, do we still need to rename the class? We don't put IT suffix for any other integration test - Keeping PinotSinkIntegrationTest as is - Renamed PinotSinkIntegrationTestUpsertTable -> PinotSinkUpsertTableIntegrationTest for naming consistency I think this config in base [pom.xml](https://github.com/apache/pinot/blob/master/pom.xml#L2587) is confusing for naming convention then. Anything not in inclustion list is getting ignores so we don't need to explicity exclude *IT.java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
