jineshparakh commented on code in PR #18203:
URL: https://github.com/apache/pinot/pull/18203#discussion_r3108692724
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##########
@@ -493,6 +498,38 @@ public void start()
_responseStore.init(responseStoreConfiguration.subset(_responseStore.getType()),
_hostname, _port, brokerId,
_brokerMetrics, expirationTime);
+ LOGGER.info("Starting ResponseStore cleanup scheduler");
+ _responseStoreCleanupExecutor = Executors.newSingleThreadScheduledExecutor(
+ runnable -> new Thread(runnable, "ResponseStoreCleanup"));
+ long cleanupFrequencyMs = TimeUtils.convertPeriodToMillis(
+
_brokerConf.getProperty(CommonConstants.CursorConfigs.RESPONSE_STORE_CLEANER_FREQUENCY_PERIOD,
+
CommonConstants.CursorConfigs.DEFAULT_RESPONSE_STORE_CLEANER_FREQUENCY_PERIOD));
+ Preconditions.checkArgument(cleanupFrequencyMs > 0,
+ "Invalid config '%s': cleanup frequency must be positive, got %s ms",
+ CommonConstants.CursorConfigs.RESPONSE_STORE_CLEANER_FREQUENCY_PERIOD,
cleanupFrequencyMs);
+ String initialDelayStr =
+
_brokerConf.getProperty(CommonConstants.CursorConfigs.RESPONSE_STORE_CLEANER_INITIAL_DELAY);
Review Comment:
Removed the config.
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##########
@@ -493,6 +498,38 @@ public void start()
_responseStore.init(responseStoreConfiguration.subset(_responseStore.getType()),
_hostname, _port, brokerId,
_brokerMetrics, expirationTime);
+ LOGGER.info("Starting ResponseStore cleanup scheduler");
+ _responseStoreCleanupExecutor = Executors.newSingleThreadScheduledExecutor(
+ runnable -> new Thread(runnable, "ResponseStoreCleanup"));
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
