jineshparakh commented on code in PR #18203:
URL: https://github.com/apache/pinot/pull/18203#discussion_r3110880063
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -2233,11 +2233,12 @@ public static class CursorConfigs {
public static final String DEFAULT_RESULTS_EXPIRATION_INTERVAL = "1h"; //
1 hour.
public static final String RESULTS_EXPIRATION_INTERVAL =
PREFIX_OF_CONFIG_OF_RESPONSE_STORE + ".expiration";
+ // Read once at broker startup; changes require broker restart to take
effect.
public static final String RESPONSE_STORE_CLEANER_FREQUENCY_PERIOD =
- "controller.cluster.response.store.cleaner.frequencyPeriod";
+ PREFIX_OF_CONFIG_OF_RESPONSE_STORE + ".cleaner.frequencyPeriod";
Review Comment:
@xiangfu0 I understand that the older configs might cause compatibility
issues.
But since we're moving the cursor cleanup from controller to broker, I think
in most deployments controller configs will not be available on the broker.
Please do let me know if this is not the case.
Does it still make sense to keep the `controller.*` configs are deprecated
and legacy as a fallback to new `broker.*` configs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
