gortiz commented on code in PR #18322:
URL: https://github.com/apache/pinot/pull/18322#discussion_r3138586637
##########
pinot-controller/pom.xml:
##########
@@ -163,7 +163,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
- <configuration combine.children="override">
+ <configuration>
Review Comment:
`combine.children="override"` is not supported in maven 4 and it only makes
sense for arrays.
##########
pinot-common/pom.xml:
##########
@@ -46,13 +46,13 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
- <configuration combine.children="override">
+ <configuration>
Review Comment:
`combine.children="override"` is not supported in maven 4 and it only makes
sense for arrays.
##########
pom.xml:
##########
@@ -111,6 +111,8 @@
<pinot.root>${basedir}</pinot.root>
<build.profile.id>dev</build.profile.id>
<jdk.version>11</jdk.version>
+ <!-- OS classifier for platform-specific protoc/grpc binaries, overridden
by OS detection profiles -->
+ <os.detected.classifier>linux-x86_64</os.detected.classifier>
Review Comment:
We add this because we are going to remove `kr.motd.maven:os-maven-plugin`.
It doesn't work properly with Maven 4 and it doesn't make much sense to use an
unsupported plugin for this. We can do the same using profiles.
##########
pom.xml:
##########
@@ -437,16 +489,16 @@
</plugins>
</build>
</profile>
- <!-- Apple Silicon Mac with Homebrew for protoc -->
+ <!-- Apple Silicon Mac with protoc-gen-grpc-java at /usr/local (fallback
path) -->
Review Comment:
We need to make this a bit more complex than before because Maven 4 does not
support mixing `<missing>` with `exists`. Then we create 2 profiles to
simulate the same thing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
