gortiz commented on code in PR #18322:
URL: https://github.com/apache/pinot/pull/18322#discussion_r3154293739
##########
pom.xml:
##########
@@ -111,6 +111,8 @@
<pinot.root>${basedir}</pinot.root>
<build.profile.id>dev</build.profile.id>
<jdk.version>11</jdk.version>
+ <!-- OS classifier for platform-specific protoc/grpc binaries, overridden
by OS detection profiles -->
+ <os.detected.classifier>linux-x86_64</os.detected.classifier>
Review Comment:
Yep, that's exactly right. `linux-x86_64` is the default, and it matches the
previous behavior:
- Before (with os-maven-plugin): The plugin would detect the OS at build
time and set `os.detected.classifier`. If the plugin failed or wasn't loaded
(which is what happens on Maven 4), the property would be unset — causing a
build error. There was no explicit fallback.
- After (with profiles): The property defaults to `linux-x86_64` in
`<properties>`. The four OS detection profiles (os-detect-linux-aarch64,
os-detect-osx-x86_64, os-detect-osx-aarch64, os-detect-windows-x86_64) activate
automatically and override the default when matched.
So: same behavior as before on every supported platform, plus a safe
fallback instead of an unset-property error on unknown platforms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
