tarun11Mavani commented on code in PR #18368:
URL: https://github.com/apache/pinot/pull/18368#discussion_r3200142330
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/StandardIndexes.java:
##########
@@ -79,6 +82,7 @@ public class StandardIndexes {
public static final String TEXT_ID = "text_index";
public static final String H3_ID = "h3_index";
public static final String VECTOR_ID = "vector_index";
+ public static final String COLUMNAR_MAP_ID = "columnar_map";
Review Comment:
There's already a MAP concept in the codebase. The existing `MapIndexReader`
/ `MapDataSource` / `MapColumnPreIndexStatsCollector` family represents the
non-columnar MAP storage path. Naming the new index type MAP would collide with
that established concept and make it unclear which path a given piece of code
refers to.
Naming it columnar_map also calls out how it's stored clearly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
