anuragrai16 commented on code in PR #18368:
URL: https://github.com/apache/pinot/pull/18368#discussion_r3224124191
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/datasource/MapDataSource.java:
##########
@@ -25,28 +25,28 @@
public interface MapDataSource extends DataSource {
- /**
- * Get the map FieldSpec.
- */
+ /// Returns the map FieldSpec.
ComplexFieldSpec.MapFieldSpec getFieldSpec();
- /**
- * Get the Data Source representation of a single key within this map column.
- */
+ /// Returns the DataSource for the given map key. For absent keys, returns a
[NullDataSource]
+ /// that produces the column default value for every document. Callers need
not null-check.
DataSource getKeyDataSource(String key);
- /**
- * Get the Data Source representation of all keys within this map column.
- */
+ /// Returns whether this segment MAY contain the given key. Implementations
are allowed to return
+ /// `true` conservatively (i.e., when it is not possible to determine key
presence without a
+ /// full scan). Callers must handle the case where the key is absent even
when this returns
+ /// `true` — [#getKeyDataSource(String)] will return a DataSource for an
absent key
+ /// (forward-index reads return the column default value; null-value bitmap
marks all rows as null).
+ default boolean containsKey(String key) {
Review Comment:
mayContainsKey* based on the description ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
