krishan1390 commented on code in PR #18381:
URL: https://github.com/apache/pinot/pull/18381#discussion_r3231758860
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -994,7 +1034,12 @@ protected void reloadSegment(SegmentDataManager
segmentDataManager, IndexLoading
+ "Change the cluster config: {} to `PROTECTED` for safer
commit", segmentName, config.getConfigKey());
} else {
_logger.info("Reloading (force committing) consuming segment: {}",
segmentName);
- ((RealtimeSegmentDataManager) segmentDataManager).forceCommit();
+ _segmentReloadSemaphore.acquire(segmentName, _logger);
Review Comment:
Since we were capturing the semaphore earlier too for force commit, we're
doing it now too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
