krishan1390 commented on code in PR #18381:
URL: https://github.com/apache/pinot/pull/18381#discussion_r3248181107
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/data/manager/TableDataManager.java:
##########
@@ -194,6 +194,13 @@ void offloadSegment(String segmentName)
void offloadSegmentUnsafe(String segmentName)
throws Exception;
+ /**
+ * Deletes a segment from this table — offloads it if currently loaded, then
removes its on-disk data (the per-segment
+ * directory and any tier-specific artefacts).
+ */
+ void deleteSegment(String segmentName)
Review Comment:
compile break is better than throwing UnsupportedOperationException or
delegating to BaseTableDataManager.deleteSegmentFilesFromDisk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
