mcvsubbu commented on a change in pull request #4713: Refactoring realtime segment committer URL: https://github.com/apache/incubator-pinot/pull/4713#discussion_r343940915
########## File path: pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java ########## @@ -76,12 +76,9 @@ import org.slf4j.LoggerFactory; import org.testng.Assert; -import static org.apache.pinot.common.utils.CommonConstants.Helix.Instance.ADMIN_PORT_KEY; -import static org.apache.pinot.common.utils.CommonConstants.Helix.LEAD_CONTROLLER_RESOURCE_ENABLED_KEY; -import static org.apache.pinot.common.utils.CommonConstants.Helix.LEAD_CONTROLLER_RESOURCE_NAME; -import static org.apache.pinot.common.utils.CommonConstants.Helix.UNTAGGED_BROKER_INSTANCE; -import static org.apache.pinot.common.utils.CommonConstants.Helix.UNTAGGED_SERVER_INSTANCE; -import static org.apache.pinot.common.utils.CommonConstants.Server.DEFAULT_ADMIN_API_PORT; +import static org.apache.pinot.common.utils.CommonConstants.Helix.Instance.*; Review comment: Not sure why you made this change. We try not to import * but have individual imports as needed. There seems to be no other change to this file. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
