mcvsubbu commented on a change in pull request #4713: Refactoring realtime
segment committer
URL: https://github.com/apache/incubator-pinot/pull/4713#discussion_r348857240
##########
File path:
pinot-core/src/test/java/org/apache/pinot/core/data/readers/PinotSegmentUtil.java
##########
@@ -80,7 +79,8 @@ static boolean compareMultiValueColumn(Object value1, Object
value2) {
return value1Set.containsAll(value2Set);
}
- static File createSegment(Schema schema, String segmentName, String
segmentOutputDir, RecordReader recordReader)
+ @VisibleForTesting
Review comment:
this class is already in test, so you don't need the annotation here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
