Akanksha-kedia commented on code in PR #18700:
URL: https://github.com/apache/pinot/pull/18700#discussion_r3420848543
##########
pinot-core/src/main/java/org/apache/pinot/core/routing/LogicalTableRouteInfo.java:
##########
@@ -98,13 +98,15 @@ public Map<ServerRoutingInstance, InstanceRequest>
getRequestMap(long requestId,
Map<ServerRoutingInstance, InstanceRequest> requestMap = new HashMap<>();
+ ServerInstance.RoutingType routingType =
Review Comment:
Fixed in the latest commit. Added a PREFER_NETTY_TLS routing type that
preserves the original fallback semantics: use TLS when the server advertises a
TLS port, fall back to plain Netty otherwise. This mirrors the deprecated
toServerRoutingInstance(tableType, boolean preferNettyTls) overload exactly.
LogicalTableRouteInfo.getRequestMap and
ImplicitHybridTableRouteInfo.getRequestMapFromRoutingTable now use
PREFER_NETTY_TLS. NETTY_TLS is kept for callers that want to hard-require TLS.
@xiangfu0 could you re-review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
