Akanksha-kedia commented on code in PR #18700:
URL: https://github.com/apache/pinot/pull/18700#discussion_r3420850341
##########
pinot-core/src/main/java/org/apache/pinot/core/transport/QueryRouter.java:
##########
@@ -151,9 +151,11 @@ private void markQueryFailed(long requestId,
ServerRoutingInstance serverRouting
public boolean hasChannel(ServerInstance serverInstance) {
if (_serverChannelsTls != null) {
- return
_serverChannelsTls.hasChannel(serverInstance.toServerRoutingInstance(TableType.OFFLINE,
true));
+ return _serverChannelsTls.hasChannel(
Review Comment:
Fixed in the same commit. QueryRouter.hasChannel() and connect() now use
PREFER_NETTY_TLS instead of NETTY_TLS when _serverChannelsTls \!= null. This
probes/connects via TLS if the server has a TLS port, and silently falls back
to plain Netty otherwise — matching the behaviour of the deprecated boolean
overload and making mixed-version clusters safe. @xiangfu0 could you re-review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
