Akanksha-kedia commented on code in PR #17072:
URL: https://github.com/apache/pinot/pull/17072#discussion_r3448132096
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/TableConfigBuilder.java:
##########
@@ -76,9 +75,8 @@ public class TableConfigBuilder {
@Deprecated
private String _segmentPushFrequency;
- // TODO: Remove 'DEFAULT_SEGMENT_PUSH_TYPE' in the future major release.
@Deprecated
- private String _segmentPushType = DEFAULT_SEGMENT_PUSH_TYPE;
Review Comment:
That was the original intent — this PR removes `DEFAULT_SEGMENT_PUSH_TYPE`
(the constant itself) and its direct usages. The deprecated `_segmentPushType`
/ `_segmentPushFrequency` builder fields are being handled in a separate PR
(#18472) to keep the blast radius small. Happy to consolidate into a single PR
if you'd prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
