Akanksha-kedia opened a new pull request, #18897: URL: https://github.com/apache/pinot/pull/18897
## Description Remove the deprecated `DEFAULT_SEGMENT_PUSH_TYPE` constant from `TableConfigBuilder`. The string literal `"APPEND"` is now inlined at the two usage sites (field initializer and fallback branch in `setSegmentPushType()`). The associated TODO comment requesting this removal is also deleted. The `_segmentPushType` field and `setSegmentPushType()` method remain in place (they are independently marked `@Deprecated`) so all existing callers continue to compile and behave identically. Note: the similarly-named `DEFAULT_SEGMENT_PUSH_TYPE` in `SegmentGenerationAndPushTaskGenerator` is a separate, non-deprecated constant of type `BatchConfigProperties.SegmentPushType` and is intentionally left untouched. ## Related Issue Fixes #17072 ## Changes Made - Removed `private static final String DEFAULT_SEGMENT_PUSH_TYPE = "APPEND"` from `TableConfigBuilder` - Replaced its two usages with the inline literal `"APPEND"` - Removed the `// TODO: Remove 'DEFAULT_SEGMENT_PUSH_TYPE' in the future major release.` comment ## Testing Done - [x] `mvn spotless:apply -pl pinot-spi` — passes - [x] `mvn checkstyle:check -pl pinot-spi` — passes - [x] `mvn license:format -pl pinot-spi` — passes - [x] `mvn -pl pinot-spi -am test-compile` — compiles cleanly ## Upgrade Notes No breaking change. The removed constant was `private` and had no external visibility. All public API behavior is preserved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
