xiangfu0 commented on code in PR #18818:
URL: https://github.com/apache/pinot/pull/18818#discussion_r3449515851
##########
pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufMessageDecoder.java:
##########
@@ -43,13 +46,16 @@ public class ProtoBufMessageDecoder implements
StreamMessageDecoder<byte[]> {
@Override
public void init(Map<String, String> props, Set<String> fieldsToRead, String
topicName)
- throws Exception {
+ throws Exception {
Preconditions.checkState(props.containsKey(DESCRIPTOR_FILE_PATH),
- "Protocol Buffer schema descriptor file must be provided");
+ "Property '%s' must be specified for ProtoBufMessageDecoder. "
+ + "If you are using Confluent Schema Registry, use "
+ + "KafkaConfluentSchemaRegistryProtoBufMessageDecoder
instead.",
+ DESCRIPTOR_FILE_PATH);
_protoClassName = props.getOrDefault(PROTO_CLASS_NAME, "");
InputStream descriptorFileInputStream =
ProtoBufUtils.getDescriptorFileInputStream(
- props.get(DESCRIPTOR_FILE_PATH));
+ props.get(DESCRIPTOR_FILE_PATH));
Review Comment:
indentation is wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
