xiangfu0 commented on code in PR #18818:
URL: https://github.com/apache/pinot/pull/18818#discussion_r3449518686
##########
pinot-plugins/pinot-input-format/pinot-protobuf/src/test/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufMessageDecoderTest.java:
##########
@@ -154,4 +155,24 @@ public void testCompositeMessage()
assertEquals(((Map<String, Object>)
destination.getValue("sample_record")).get("name"), "Alice");
assertEquals(((Map<String, Object>)
destination.getValue("sample_record")).get("id"), 18);
}
+
+ @Test
+ public void testInitThrowsHelpfulMessageWhenDescriptorFileMissing() {
Review Comment:
no point to add test for this
##########
pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufMessageDecoder.java:
##########
@@ -32,7 +32,10 @@
import org.apache.pinot.spi.stream.StreamMessageDecoder;
-//TODO: Add support for Schema Registry
+// This decoder is intentionally file-based and does not support schema
registry.
+// For Confluent Schema Registry-backed descriptor resolution, use
+// KafkaConfluentSchemaRegistryProtoBufMessageDecoder instead.
Review Comment:
use markdown style and the comments should start with `///`
##########
pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufMessageDecoder.java:
##########
@@ -43,13 +46,16 @@ public class ProtoBufMessageDecoder implements
StreamMessageDecoder<byte[]> {
@Override
public void init(Map<String, String> props, Set<String> fieldsToRead, String
topicName)
- throws Exception {
+ throws Exception {
Review Comment:
indentation is wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
