This is an automated email from the ASF dual-hosted git repository.
xiangfu0 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new bf58476d375 Mark numMinionSubtasks* gauges as non-global to match PR
#18854 Prometheus rule (#18864)
bf58476d375 is described below
commit bf58476d37583276011f7dd741e3a49f495c047e
Author: Samuel Papin <[email protected]>
AuthorDate: Fri Jun 26 22:23:40 2026 -0400
Mark numMinionSubtasks* gauges as non-global to match PR #18854 Prometheus
rule (#18864)
---
.../prometheus/ControllerPrometheusMetricsTest.java | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git
a/pinot-common/src/test/java/org/apache/pinot/common/metrics/prometheus/ControllerPrometheusMetricsTest.java
b/pinot-common/src/test/java/org/apache/pinot/common/metrics/prometheus/ControllerPrometheusMetricsTest.java
index 67a8ccac12c..c4e70fbad30 100644
---
a/pinot-common/src/test/java/org/apache/pinot/common/metrics/prometheus/ControllerPrometheusMetricsTest.java
+++
b/pinot-common/src/test/java/org/apache/pinot/common/metrics/prometheus/ControllerPrometheusMetricsTest.java
@@ -38,23 +38,22 @@ public abstract class ControllerPrometheusMetricsTest
extends PinotPrometheusMet
//that accept global gauge with suffix
private static final List<ControllerGauge> GLOBAL_GAUGES_ACCEPTING_TASKTYPE =
- List.of(ControllerGauge.NUM_MINION_TASKS_IN_PROGRESS,
ControllerGauge.NUM_MINION_SUBTASKS_RUNNING,
- ControllerGauge.NUM_MINION_SUBTASKS_WAITING,
ControllerGauge.NUM_MINION_SUBTASKS_ERROR,
- ControllerGauge.NUM_MINION_SUBTASKS_UNKNOWN,
- ControllerGauge.NUM_MINION_SUBTASKS_DROPPED,
- ControllerGauge.NUM_MINION_SUBTASKS_TIMED_OUT,
- ControllerGauge.NUM_MINION_SUBTASKS_ABORTED,
- ControllerGauge.PERCENT_MINION_SUBTASKS_IN_QUEUE,
ControllerGauge.PERCENT_MINION_SUBTASKS_IN_ERROR);
+ List.of(ControllerGauge.NUM_MINION_TASKS_IN_PROGRESS);
//local gauges that accept partition
private static final List<ControllerGauge> GAUGES_ACCEPTING_PARTITION =
List.of(ControllerGauge.MAX_RECORDS_LAG,
ControllerGauge.MAX_RECORD_AVAILABILITY_LAG_MS);
- //these accept task type
+ //these accept task type (per-table scoped)
private static final List<ControllerGauge> GAUGES_ACCEPTING_TASKTYPE =
List.of(ControllerGauge.TIME_MS_SINCE_LAST_MINION_TASK_METADATA_UPDATE,
ControllerGauge.TIME_MS_SINCE_LAST_SUCCESSFUL_MINION_TASK_GENERATION,
- ControllerGauge.LAST_MINION_TASK_GENERATION_ENCOUNTERS_ERROR);
+ ControllerGauge.LAST_MINION_TASK_GENERATION_ENCOUNTERS_ERROR,
+ ControllerGauge.NUM_MINION_SUBTASKS_RUNNING,
ControllerGauge.NUM_MINION_SUBTASKS_WAITING,
+ ControllerGauge.NUM_MINION_SUBTASKS_ERROR,
ControllerGauge.NUM_MINION_SUBTASKS_UNKNOWN,
+ ControllerGauge.NUM_MINION_SUBTASKS_DROPPED,
ControllerGauge.NUM_MINION_SUBTASKS_TIMED_OUT,
+ ControllerGauge.NUM_MINION_SUBTASKS_ABORTED,
+ ControllerGauge.PERCENT_MINION_SUBTASKS_IN_QUEUE,
ControllerGauge.PERCENT_MINION_SUBTASKS_IN_ERROR);
private static final List<ControllerGauge> GAUGES_ACCEPTING_RAW_TABLENAME =
List.of();
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
