RajaVinoth96 commented on code in PR #18751:
URL: https://github.com/apache/pinot/pull/18751#discussion_r3487602920
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -1674,6 +1668,12 @@ private static void
validateIndexingConfigAndFieldConfigList(TableConfig tableCo
FieldSpec fieldSpec = schema.getFieldSpecFor(column);
Preconditions.checkState(fieldSpec != null, "Failed to find sorted
column: %s in schema", column);
Preconditions.checkState(fieldSpec.isSingleValueField(), "Cannot sort
on multi-value column: %s", column);
+ FieldIndexConfigs indexConfigsForSortedColumn =
indexConfigsMap.get(column);
+ for (IndexType indexType : List.of(StandardIndexes.bloomFilter(),
StandardIndexes.inverted(),
+ StandardIndexes.range())) {
+
Preconditions.checkState(indexConfigsForSortedColumn.getConfig(indexType).isDisabled(),
+ "Redundant to enable %s on a sorted column: %s",
indexType.getPrettyName(), fieldSpec.getName());
+ }
Review Comment:
Removing the check for bloom filter since it acts at a segment level , the
remaining are redundant when the columns are not sorted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
