RajaVinoth96 commented on code in PR #18751:
URL: https://github.com/apache/pinot/pull/18751#discussion_r3520773669


##########
pinot-core/src/test/resources/TableIndexingTest.csv:
##########
@@ -112,24 +112,24 @@ FLOAT;mv;raw;multi_col_text_index;false;Cannot create 
TEXT index on column: col
 FLOAT;sv;dict;timestamp_index;false;Cannot create TIMESTAMP index on column: 
col of stored type other than LONG
 FLOAT;sv;dict;bloom_filter;true;
 FLOAT;sv;dict;fst_index;false;Cannot create FST index on column: col of stored 
type other than STRING
-FLOAT;sv;dict;h3_index;false;Cannot create H3 index on column: col of stored 
type other than BYTES
+FLOAT;sv;dict;h3_index;false;Anti pattern to enable both dictionary index and 
h3 on column: col
 FLOAT;sv;dict;inverted_index;true;
-FLOAT;sv;dict;json_index;false;Cannot create JSON index on column: col of 
stored type other than STRING or MAP
-FLOAT;sv;dict;text_index;false;Cannot create TEXT index on column: col of 
stored type other than STRING
+FLOAT;sv;dict;json_index;false;Anti pattern to enable both dictionary index 
and json on column: col
+FLOAT;sv;dict;text_index;false;Anti pattern to enable both dictionary index 
and text on column: col
 FLOAT;sv;dict;range_index;true;
 FLOAT;sv;dict;startree_index;true;
-FLOAT;sv;dict;vector_index;false;Cannot create vector index on single-value 
column: col
+FLOAT;sv;dict;vector_index;false;Anti pattern to enable both dictionary index 
and vector on column: col
 FLOAT;sv;dict;multi_col_text_index;false;Cannot create TEXT index on column: 
col of stored type other than STRING
 FLOAT;mv;dict;timestamp_index;false;Cannot create TIMESTAMP index on column: 
col of stored type other than LONG
 FLOAT;mv;dict;bloom_filter;true;
 FLOAT;mv;dict;fst_index;false;Cannot create FST index on multi-value column: 
col
-FLOAT;mv;dict;h3_index;false;Cannot create H3 index on multi-value column: col
+FLOAT;mv;dict;h3_index;false;Anti pattern to enable both dictionary index and 
h3 on column: col
 FLOAT;mv;dict;inverted_index;true;
-FLOAT;mv;dict;json_index;false;Cannot create JSON index on multi-value column: 
col
-FLOAT;mv;dict;text_index;false;Cannot create TEXT index on column: col of 
stored type other than STRING
+FLOAT;mv;dict;json_index;false;Anti pattern to enable both dictionary index 
and json on column: col
+FLOAT;mv;dict;text_index;false;Anti pattern to enable both dictionary index 
and text on column: col
 FLOAT;mv;dict;range_index;true;
 FLOAT;mv;dict;startree_index;false;Star-tree dimension columns must be 
single-value, but found multi-value column: col
-FLOAT;mv;dict;vector_index;true;
+FLOAT;mv;dict;vector_index;Anti pattern to enable both dictionary index and 
vector on column: col;

Review Comment:
   resolved



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to