RajaVinoth96 commented on PR #18751: URL: https://github.com/apache/pinot/pull/18751#issuecomment-4940899335
> > Can you explain the rationale behind these anti pattern combinations? We only want to block invalid setups (where the code will throw exception). These "anti pattern" combinations can break valid setups. E.g. we want to use dictionary for low cardinality columns, but we can also put JSON index on the column > > My understanding was that we need to be disabling index combinations that dont actually go well . My analysis ( that is reading about it in AI tools) suggested that combinations like text and json on the same index is wasteful. Hence the validation checks with invalid error. > > Do you want me to revert these changes and only work on those that cause runtime errors?. @Jackie-Jiang Can you please advice on which files to check?. Json And Text are both not necessary on the same column from what i found. Few of the errors in pinot-core/src/test/resources/TableIndexingTest.csv like https://github.com/apache/pinot/blob/master/pinot-core/src/test/resources/TableIndexingTest.csv#L315 and https://github.com/apache/pinot/blob/master/pinot-core/src/test/resources/TableIndexingTest.csv#L338. Give me a few pointers please and i will rework this pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
